*: test coverage improvements #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a set of tests to the fairly trivial idtools package, with 100% test coverage. Signed-off-by: Aleksa Sarai <asarai@suse.com>
These tests are part of libcontainer/user, but they were dropped because I didn't bother to figure out why the build failed. I've figured it out, and now the tests build. Signed-off-by: Aleksa Sarai <asarai@suse.com>
This now includes all of the coverage stats for umoci during integration testing. This stilll needs to be combined with unit tests to get a proper sense of the overall statistics. Signed-off-by: Aleksa Sarai <asarai@suse.com>
This means that we can compute the total coverage information for the whole codebase, which is hard to do otherwise. Signed-off-by: Aleksa Sarai <asarai@suse.com>
Removed unused code, added tests and cleaned up some test code. We've now hit the ~80% coverage target. So it's looking much better than before. Signed-off-by: Aleksa Sarai <asarai@suse.com>
Signed-off-by: Aleksa Sarai <asarai@suse.com>
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a lot of improvements to test coverage. In addition to adding
more tests, the main cool thing is that we now generate coverage reports that
cover all of the testing done in
umoci, so you can get a sense for howtested the whole codebase is. Currently I'm aiming to get ~80% test coverage.
Fixes #67
Signed-off-by: Aleksa Sarai asarai@suse.com