*: clean up logging #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apex/log has much more useful handlers (formatters) for CLI tools. In partciular, the "cli" handler is much better suited to command-line tooling than any formatter available for logrus. Signed-off-by: Aleksa Sarai <asarai@suse.de>
This is necessary to make it more obvious to users what is going on. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Add custom logging levels, defaulting to the logging level of warning. This makes the output much less spammy. Signed-off-by: Aleksa Sarai <asarai@suse.de>
runcom
reviewed
Feb 6, 2017
| log.SetHandler(logcli.New(os.Stderr)) | ||
|
|
||
| if ctx.GlobalBool("verbose") { | ||
| if ctx.GlobalIsSet("log") { |
There was a problem hiding this comment.
You may want to no-op on log=info?
There was a problem hiding this comment.
I'd prefer to make it so people don't mix the two at all. But thanks for the review.
|
Looks good! |
|
Thanks @runcom! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apex/log has much more useful handlers (formatters) for CLI tools. In
partciular, the "cli" handler is much better suited to command-line
tooling than any formatter available for logrus.
Add custom logging levels, defaulting to the logging level of warning.
This makes the output much less spammy.
Fixes #71
Signed-off-by: Aleksa Sarai asarai@suse.de