cmd/umoci: tag: fix tag clobbering #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
master
branch
2 times, most recently
from
7d23332
to
3fd7aa0
Compare
cyphar
force-pushed
the
fix-tag-clobbering
branch
2 times, most recently
from
0ca6a11
to
660358d
Compare
Previously, tags would always be clobbered, but this logic was subtly broken for "umoci tag". Fix this by matching the other PutReference usages. Fixes: 8b73b49 ("*: make logging [log.Info] much more user-friendly") Signed-off-by: Aleksa Sarai <asarai@suse.de>
Ensure that we don't get a regression for "umoci tag" clobbering. Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tags would always be clobbered, but this logic was subtly
broken for "umoci tag". Fix this by matching the other PutReference
usages.
Ensure that we don't get a regression for "umoci tag" clobbering.
Fixes: 8b73b49 ("*: make logging [log.Info] much more user-friendly")
Signed-off-by: Aleksa Sarai asarai@suse.de