Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component types need to be unnecessarily defined #33

Closed
rikukissa opened this issue May 16, 2018 · 3 comments
Closed

Component types need to be unnecessarily defined #33

rikukissa opened this issue May 16, 2018 · 3 comments
Labels

Comments

@rikukissa
Copy link
Member

This is what's causing it:
microsoft/TypeScript#5711

So what we need to do:

import * as React from 'react'; // not referenced anywhere
import styled, { 
  StyledComponentClass /* not referenced anywhere */ 
} from 'styled-components'; 

export const Button = styled.button`
  background: red;
`;

Which leads us having to disable noUnusedLocals from tsconfig.json, which then again hides all unused variables, which is not ideal.

@rikukissa
Copy link
Member Author

Not entirely sure what happened, but I was able to get past this in https://github.com/jembi/OpenCRVS/pull/36/files#diff-2d0848abc757da0fecb95cc39e16488c

Turned noUnusedLocals back on

@rikukissa
Copy link
Member Author

Reintroduced here https://github.com/jembi/OpenCRVS/pull/36/files

@rikukissa rikukissa reopened this May 22, 2018
@rikukissa
Copy link
Member Author

I don't think this is a problem anymore

gitbook-com bot pushed a commit that referenced this issue Jun 1, 2022
gitbook-com bot pushed a commit that referenced this issue Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant