Optimise Docker builds #6919
Merged
Optimise Docker builds #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1koo
force-pushed
the
optimise_docker_builds
branch
2 times, most recently
from
012465d
to
f905f35
Compare
n1koo
changed the title
rikukissa
approved these changes
May 13, 2024
n1koo
force-pushed
the
optimise_docker_builds
branch
from
a7e7f1a
to
6d8c078
Compare
n1koo
force-pushed
the
optimise_docker_builds
branch
2 times, most recently
from
d6cd559
to
39ad3d7
Compare
rikukissa
approved these changes
May 27, 2024
packages/workflow/Dockerfile
Outdated
|
|
||
| RUN yarn install | ||
| RUN yarn install --frozen-lockfile --ignore-scripts |
There was a problem hiding this comment.
What's the ignore-scripts here?
rikukissa
reviewed
Jun 11, 2024
docker-compose.yml
Outdated
Comment on lines
12
to
16
| base: | ||
| image: opencrvs/ocrvs-base:${VERSION} | ||
| build: | ||
| context: . | ||
| dockerfile: ./packages/Dockerfile.base |
There was a problem hiding this comment.
Do we need to define the base image here? The reason I'm asking is I noticed deployment failing with
Server failed to download opencrvs/ocrvs-base:3f89c3d
when I built images from this branch and deployed. Based on this depends_on also should control the order services start up but we don't run anything for base outside build, right?
https://docs.docker.com/compose/compose-file/05-services/#depends_on
n1koo
force-pushed
the
optimise_docker_builds
branch
4 times, most recently
from
907f01c
to
2ab1195
Compare
…imise disk size etc.
n1koo
force-pushed
the
optimise_docker_builds
branch
2 times, most recently
from
6a23862
to
6576893
Compare
…ling due problematic watcher dependency
n1koo
force-pushed
the
optimise_docker_builds
branch
from
6576893
to
e7bdb5c
Compare
This was referenced Jun 21, 2024
rikukissa
approved these changes
Jun 25, 2024
…mise_docker_builds
rikukissa
added a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6902
alpinetodebian-slim.dockerignoreand more specific buildsPart of this we also
versionfrom compose fileslernato latest to address gyp: binding.gyp not found (...) while trying to load binding.gyp parcel-bundler/watcher#156@graphql-codegen/addand@graphql-codegen/clito also address gyp: binding.gyp not found (...) while trying to load binding.gyp parcel-bundler/watcher#156Requires opencrvs/opencrvs-countryconfig#160 to be merged at the same time to ensure deploys dont break on the new baseimage