Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(env-vars): auth environment validation #7621

Merged
merged 9 commits into from
Oct 1, 2024
Merged

refactor(env-vars): auth environment validation #7621

merged 9 commits into from
Oct 1, 2024

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Sep 17, 2024 •
edited
Loading

#5932

Refactors auth to use envalid and enforce setting environment variables in production.

@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis changed the title refactor: use envalid in auth refactor(env-vars): auth Sep 18, 2024
@naftis naftis changed the title refactor(env-vars): auth refactor(env-vars): auth environment validation Sep 18, 2024
@naftis naftis added this to the v1.7.0 milestone Sep 18, 2024
naftis and others added 2 commits September 26, 2024 21:43
@naftis @rikukissa
fix: AUTH_HOST and AUTH_PORT can be default
77abf34 
they are rarely being re-configured while this allows for that.

Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com>
@rikukissa
Merge branch 'develop' into ocrvs-5932-auth
61c0da9
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-5932-auth.opencrvs.dev.

@naftis naftis merged commit 83f8172 into develop Oct 1, 2024
39 checks passed
@naftis naftis deleted the ocrvs-5932-auth branch October 1, 2024 06:52
@naftis naftis restored the ocrvs-5932-auth branch October 1, 2024 06:52
@naftis naftis deleted the ocrvs-5932-auth branch October 1, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa rikukissa approved these changes

Assignees
No one assigned
Labels
✅ Ready for merging
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@naftis @ocrvs-bot @rikukissa