Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: amend legacy scopes of config #7897

Open
wants to merge 4 commits into
base: configurable-roles
Choose a base branch
from

Conversation

Nil20
Copy link
Collaborator

@Nil20 Nil20 commented Nov 5, 2024

No description provided.

Copy link

github-actions bot commented Nov 5, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Comment on lines 66 to 67
(scope.includes(SCOPES.RECORD_SUBMIT_FOR_APPROVAL) ||
scope.includes(SCOPES.CONFIG_UPDATE_ALL))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certificates are required by whomever can print? So record.declaration-print or record.registration-print&issue-certified-copies

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. record.declaration-print is probably just for printing the record. So the latter one should be the one to go.

packages/config/src/config/routes.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants