Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the confusing configuration name #2597

Closed
wuhongsong opened this issue Jun 30, 2023 · 3 comments
Closed

Change the confusing configuration name #2597

wuhongsong opened this issue Jun 30, 2023 · 3 comments
Assignees
Labels
enhancement improve feature

Comments

@wuhongsong
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)
Change the confusing configuration name: s3.enableDeleteObjects

what enableDeleteObjects means in curve now?
whether support batch delete objects or not. so if enableDeleteObjects is false, we can delete objs any way.

His literal meaning is can not be deleted, so it will mislead people.

int S3ClientAdaptorImpl::Delete(const Inode &inode) { if (enableDeleteObjects_) { return DeleteInodeByDeleteBatchChunk(inode); } else { return DeleteInodeByDeleteSingleChunk(inode); } }

Describe the solution you'd like (描述你期望的解决方法)

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@Jason011125
Copy link

Could you please specify which file s3.enableDeleteObjects is located as I couldn't find it in the s3.conf file. Thanks a lot!

@wuhongsong
Copy link
Contributor Author

Could you please specify which file s3.enableDeleteObjects is located as I couldn't find it in the s3.conf file. Thanks a lot!
metaserver.cpp

@wuhongsong
Copy link
Contributor Author

#2597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve feature
Projects
None yet
Development

No branches or pull requests

3 participants