[feat]tools-v2: curve bs create clone #2639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lng2020
changed the title
Cyber-SiKu
reviewed
Jul 31, 2023
There was a problem hiding this comment.
The command should be two:
curve bs create volume clone
curve bs create volume recoverThey all use the same rpc request, but the parameters are not available.
You can abstract this rpc request, and then call it separately by the above commands. For this, you can refer to create file/dir.
Cyber-SiKu
reviewed
Jul 31, 2023
|
will do |
|
@lng2020 continue？ |
|
@lng2020 any trouble? |
|
wait for #2713 to merge. Those commands are highly associated, with basically the exact solutions. |
merged |
lng2020
force-pushed
the
feature/curve-bs-create-clone
branch
from
f605538
to
116f563
Compare
Signed-off-by: lng2020 <nanguanlin6@gmail.com>
lng2020
force-pushed
the
feature/curve-bs-create-clone
branch
from
116f563
to
0abe9b3
Compare
|
@lng2020 continue? |
No. Sorry about that. But it's almost finished. Maybe others can refer this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2586
Problem Summary: add
curve bs create clonecommandWhat is changed and how it works?
What's Changed: ./pkg/cli/command/curvebs/create/create.go, ./pkg/cli/command/curvebs/create/clone and ./pkg/internal/error/error.go
How it Works: send
CreateCloneFileRequestto clone fileSide effects(Breaking backward compatibility? Performance regression?):
Check List