Log retention of curve cluster service #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must be executed on the working node Signed-off-by: Liao PengFei <136953902+hdbdn77@users.noreply.github.com>
Signed-off-by: Liao PengFei <136953902+hdbdn77@users.noreply.github.com>
Signed-off-by: Liao PengFei <136953902+hdbdn77@users.noreply.github.com>
Signed-off-by: Liao PengFei <136953902+hdbdn77@users.noreply.github.com>
Signed-off-by: Liao PengFei <136953902+hdbdn77@users.noreply.github.com>
caoxianfei1
reviewed
Nov 20, 2023
|
|
||
| # Check if the file exists | ||
| if [ ! -f "$json_file" ]; then | ||
| die "json file ${json_file} does not exist.\n" |
There was a problem hiding this comment.
is ok？ die and success function seems to require two parameter.
There was a problem hiding this comment.
如果你调用 die 函数时只提供了一个参数，那么 ${2} 就是空的。
caoxianfei1
reviewed
Nov 20, 2023
| # Check whether interval is greater than or equal to 0 | ||
| if [[ ! ($interval =~ ^[0-9]+$) ]]; then | ||
| die "The interval parameter is invalid.\n" | ||
| elif [[ ! ($interval -ge 0) ]]; then |
There was a problem hiding this comment.
need to convert into integer and then determine?
There was a problem hiding this comment.
这个代码片段检查变量 $interval 是否为非负整数。
在数值比较中，Shell 会尝试将字符串转换为数字，如果无法转换则会置零。
caoxianfei1
reviewed
Nov 20, 2023
| # Check if compress_or_clean is equal to 0 or equal to 1 | ||
| if [[ ! ($compress_or_clean =~ ^[0-9]+$) ]]; then | ||
| die "The compress_or_clean parameter is invalid.\n" | ||
| elif [[ ! ($compress_or_clean -eq 0 || $compress_or_clean -eq 1) ]]; then |
caoxianfei1
reviewed
Nov 20, 2023
| # Check if max_tar_file is greater than or equal to 1 | ||
| if [[ ! ($max_tar_file =~ ^[0-9]+$) ]]; then | ||
| die "The max_tar_file parameter is invalid.\n" | ||
| elif [[ ! ($max_tar_file -ge 1) ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #197
Must be executed on the working node