-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to SQLAlchemy 2.0 #1432
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1432 +/- ##
===============================================
+ Coverage 91.91% 91.95% +0.04%
===============================================
Files 135 135
Lines 15088 15085 -3
===============================================
+ Hits 13868 13872 +4
+ Misses 1220 1213 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, bar the 1 line change in the GitHub actions workflow.
And even that, the whole workflow file either needs a bunch of comments to explain what's going on, or refactoring to make it less insane...
GHA workflows have long been black magic to me - I learned a lot on this PR. |
Reason for this pull request
SQLAlchemy2.0 has been released with a number of backwards incompatible API changes. Datacube-1.9 is a convenient place to deal with this.
Proposed changes
Use the new postgresql dialect Range type hierarchy.
Fix all remaining SQLA1.4 query and row access API incompatibilities.
Update
ensure_db
implementations to work with SQLA2.0 transaction defaults.Closes Migrate to SQLAlchemy 2.0 #1431
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes