Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Python version for to 3.10 (for develop-1.9 branch) #1509

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Nov 4, 2023

Reason for this pull request

Python 3.10 is cool. Especially the | operator for type hints.

Proposed changes

  • Increase minimum Python version to 3.10

  • Drop 3.9 smoke tests, add 3.12 smoke tests

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b91fe85) 85.22% compared to head (b791c8b) 85.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop-1.9    #1509   +/-   ##
============================================
  Coverage        85.22%   85.22%           
============================================
  Files              131      131           
  Lines            14551    14551           
============================================
  Hits             12401    12401           
  Misses            2150     2150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omad omad merged commit e74a27b into develop-1.9 Nov 5, 2023
25 checks passed
@omad omad deleted the minpy3.10 branch November 5, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants