Index level ep13 #1534
Merged
Index level ep13 #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote connect_to_index to ABC, as per EP-13
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1534 +/- ##
===============================================
+ Coverage 85.28% 85.33% +0.04%
===============================================
Files 139 140 +1
Lines 14971 15018 +47
===============================================
+ Hits 12768 12815 +47
Misses 2203 2203 ☔ View full report in Codecov by Sentry. |
Ariana-B
approved these changes
Jan 16, 2024
| supports_legacy = True | ||
| supports_legacy = False | ||
| # supports eo3 compatible metadata types. | ||
| supports_eo3 = False |
There was a problem hiding this comment.
Is there a benefit to including flags that will always be set to True?
There was a problem hiding this comment.
A STAC-based index driver might not support EO3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Changes to the
IndexandIndexDriverAPIs, as proposed in EP13.Proposed changes
New
index_classmethod onIndexDriverconnect_to_index()function is now implemented in the base class (callsfrom_configon the class returned byindex_class)metadata_type_from_doc()method onIndexDriverdeprecated in favour ofindex.metadata_type.from_doc()"supports" flags on
Index: New flags, as per EP13, and make all flags default to False, so drivers have to explicitly declare all the flags they DO support.Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes