Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
For complex queries (as can occur when using
search_returning
), SQLAlchemy was non-deterministically failing to resolve a join strategy. This was caused some tests to fail intermittently. A re-run (or 2, or 3) of the tests was usually sufficient to bypass but it shouldn't have been happening and needed to be addressed.Proposed changes
driver.postgis._fields
NativeField
s smart enough to generate anonclause
parameter for the SQLAjoin
function, and wire in to the query generation code.Running a temporary minimal test that triggered the issue, this change took us from failing roughly 1 run in 4 to not failing at all for 25+ sequential test runs.
docs/about/whats_new.rst
for all changes