Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "default" an alias instead of the canonical driver name. #1590

Merged
merged 3 commits into from
May 31, 2024

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

  • The canonical name of the postgres driver was "default", with "postgres" and "legacy" as aliases.
  • If dynamic driver loading failed, only the "postgres" driver was being forcibly injected.

Proposed changes

  • The canonical name of the postgres driver is "postgres", with "default" and "legacy" as aliases.
  • If dynamic driver loading fails, the "postgres", "postgis" and "memory" drivers are forcibly injected.

…"default".

(It is still the default, but "default" is now an alias.)
tests/test_driver.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (a5622d8) to head (51695e7).
Report is 36 commits behind head on develop-1.9.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop-1.9    #1590   +/-   ##
============================================
  Coverage        85.44%   85.44%           
============================================
  Files              140      140           
  Lines            15477    15479    +2     
============================================
+ Hits             13224    13226    +2     
  Misses            2253     2253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul merged commit e69ff50 into develop-1.9 May 31, 2024
30 checks passed
@SpacemanPaul SpacemanPaul deleted the index-driver-cutover branch May 31, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants