Fix some Docker warnings #1626
Merged
Fix some Docker warnings #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the warning: FromAsCasing: 'as' and 'FROM' keywords' casing do not match emitted by recent Docker releases.
This fixes the warning: LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format emitted by recent Docker releases. And while changing this, bring all the ENV lines into a single layer, which saves some space in the resulting image.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1626 +/- ##
========================================
Coverage 91.78% 91.78%
========================================
Files 132 132
Lines 14640 14640
========================================
Hits 13437 13437
Misses 1203 1203 ☔ View full report in Codecov by Sentry. |
SpacemanPaul
approved these changes
Sep 3, 2024
SpacemanPaul
added a commit
that referenced
this pull request
Sep 20, 2024
Merged
SpacemanPaul
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Fix the warnings emitted by recent Docker releases.
Proposed changes
Fix the warnings, and bring together all the ENV lines into a single layer to save a little bit of space in the produced image.
docs/about/whats_new.rstfor all changes