Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: bump flask version #542

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

pjonsson
Copy link
Contributor

Update flask to 2.2.5 to fix CVE-2023-30861
and restrict Werkzeug to <3 to fix:

ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/usr/local/lib/python3.8/dist-packages/werkzeug/urls.py)

in the integration tests.

Update flask to 2.2.5 to fix CVE-2023-30861
and restrict Werkzeug to <3 to fix:

ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/usr/local/lib/python3.8/dist-packages/werkzeug/urls.py)

in the integration tests.
Commit f385352 removed the content of
/code which is great for deployment images,
but breaks the integration tests.

Only remove .git* instead, since that is
the bulk of the size of the /code directory.
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@omad omad merged commit ebbdecd into opendatacube:develop Nov 16, 2023
4 of 6 checks passed
@pjonsson pjonsson deleted the fix-integration-tests branch November 16, 2023 10:23
@pjonsson
Copy link
Contributor Author

@omad I'm not sure bumping flask version caused a schema validation failure, do you know if the CI tests have passed recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants