Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: update to stac-api 1.0.0 #554

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 21, 2023

Update update.sh to download stac-api version 1.0.0, and then run it to update the schemas in the repository.

The changes to schemas outside integration_tests/schemas/schemas.stacspec.org/1.0.0/stac-spec are whitespace and other formatting changes to align with the upstream formatting. This makes it possible to run update.sh and do git status to see if anything has changed in the schemas upstream.

This PR is on top of #548 and #549.


📚 Documentation preview 📚: https://datacube-explorer--554.org.readthedocs.build/en/554/

@pjonsson
Copy link
Contributor Author

@omad I should probably have mentioned that this PR is part of the train to re-enable the tests from the PR that disabled them the other day.

@pjonsson
Copy link
Contributor Author

@omad I'd like to get the disabled tests re-enabled and that is on top of this cluster of PRs. Are these PRs on your radar, or is it someone else that should review them?

Reformatting will give spurious differences
after running the update.sh script.
Make the update script fix the STAC version
instead of having a comment inside the test
file.
This effectively renames the directory
called master to 1.0.0.
I am not sure if it is the schema update, or some
external change, but these versions are what are
returned from these tests now.
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7fa351) 85.88% compared to head (0c6ef0f) 85.88%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #554   +/-   ##
========================================
  Coverage    85.88%   85.88%           
========================================
  Files           26       26           
  Lines         3457     3457           
========================================
  Hits          2969     2969           
  Misses         488      488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omad omad merged commit 269ba6e into opendatacube:develop Dec 4, 2023
7 checks passed
@pjonsson pjonsson deleted the update-schemas branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants