Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Datashim #72

Open
wants to merge 1 commit into
base: v1.0-branch-openshift
Choose a base branch
from

Conversation

pkoutsov
Copy link

@pkoutsov pkoutsov commented Sep 7, 2021

Description of your changes:
Manifest for Datashim

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pkoutsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2021

Hi @pkoutsov. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nakfour
Copy link

nakfour commented Sep 15, 2021

Hi @pkoutsov thank you for the PR, we have a new process to submit new components to Open Data Hub described here: https://github.com/opendatahub-io/opendatahub-community/blob/master/GuidelinesForNewComponents.md

If you can please also open an issue to add this component here: https://issues.redhat.com/secure/RapidBoard.jspa?rapidView=8528&projectKey=ODH&view=detail&selectedIssue=ODH-447

Also I wanted to see if there is a specific reason why this component was added to manifest and not odh-manifest?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants