-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci #43
Fix ci #43
Conversation
- elazarl/goproxy [CVE-2023-37788] Denial of Service (DoS) - emicklei/go-restful [CVE-2022-1996] Authorization Bypass Through User-Controlled Key - prometheus/client_golang [CWE-400] Denial of Service (DoS) ----- Signed-off-by: Spolti <fspolti@redhat.com>
Specify and link python38 to fix build/test failures due to the wrong Python version (3.6) being used from base image. --------- Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
CI still fails... |
- Remove the linters for "deadcode", "structcheck", "varcheck" - Use "os" packages instead of deprecated "io/ioutil" (SA1019) - Capture pre-commit output in a local log file Fixes opendatahub-io#64 --------- Signed-off-by: Spolti <fspolti@redhat.com>
…-io#58) Ensure the versions of the generated protobuf code stubs are consistent with the versions as specified in the Dockerfile and the go.mo file. - protoc v3.21.5 - protoc-gen-go v1.28.1 - protoc-gen-go-grpc v1.3.0 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3d163e7
into
opendatahub-io:release-0.11.1
…ahub-io#43) #### Motivation As documented in [this issue](kserve#40), there is currently a bug in the conversion of the `uri` provided in the MLServer `model-settings.json` file if the model files are symlinked before the uri conversion occurs. This PR is intended to fix the issue by ensuring that `model-settings.json` will always be processed first. #### Modifications The function `adaptModelLayoutForRuntime` in the MLServer adapter `server.go` was modified to ensure that, if present, the `model-settings.json` file will be placed at the head of the list of files to be processed. This makes sure that the config file will always be processed before any symlinks are created for the model files. A unit test was also added to ensure that the bug was fixed. #### Result Incorrect uri conversion bug no longer occurs even when the model files alphabetically precede the filename`model-settings.json`. Signed-off-by: xinyitan <xin.yi.tan@sap.com> Co-authored-by: xinyitan <xin.yi.tan@sap.com>
Motivation
Modifications
Result