Fix ci #43
Merged
Fix ci #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- elazarl/goproxy [CVE-2023-37788] Denial of Service (DoS) - emicklei/go-restful [CVE-2022-1996] Authorization Bypass Through User-Controlled Key - prometheus/client_golang [CWE-400] Denial of Service (DoS) ----- Signed-off-by: Spolti <fspolti@redhat.com>
Specify and link python38 to fix build/test failures due to the wrong Python version (3.6) being used from base image. --------- Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
|
CI still fails... |
- Remove the linters for "deadcode", "structcheck", "varcheck" - Use "os" packages instead of deprecated "io/ioutil" (SA1019) - Capture pre-commit output in a local log file Fixes opendatahub-io#64 --------- Signed-off-by: Spolti <fspolti@redhat.com>
…-io#58) Ensure the versions of the generated protobuf code stubs are consistent with the versions as specified in the Dockerfile and the go.mo file. - protoc v3.21.5 - protoc-gen-go v1.28.1 - protoc-gen-go-grpc v1.3.0 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
israel-hdez
approved these changes
Jan 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3d163e7
into
opendatahub-io:release-0.11.1
5 checks passed
Jooho
pushed a commit
to Jooho/modelmesh-runtime-adapter
that referenced
this pull request
May 21, 2024
…ahub-io#43) #### Motivation As documented in [this issue](kserve#40), there is currently a bug in the conversion of the `uri` provided in the MLServer `model-settings.json` file if the model files are symlinked before the uri conversion occurs. This PR is intended to fix the issue by ensuring that `model-settings.json` will always be processed first. #### Modifications The function `adaptModelLayoutForRuntime` in the MLServer adapter `server.go` was modified to ensure that, if present, the `model-settings.json` file will be placed at the head of the list of files to be processed. This makes sure that the config file will always be processed before any symlinks are created for the model files. A unit test was also added to ensure that the bug was fixed. #### Result Incorrect uri conversion bug no longer occurs even when the model files alphabetically precede the filename`model-settings.json`. Signed-off-by: xinyitan <xin.yi.tan@sap.com> Co-authored-by: xinyitan <xin.yi.tan@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Result