Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move manifests to config/ #214

Conversation

VedantMahabaleshwarkar
Copy link

Motivation

  • manifests readiness for Operator v2 such that the operator can get the manifests from each component repo directly, eliminating the need to have odh-manifests

Modifications

  • put all the latest manifests for modelmesh from /opendatahub/odh-manifests and copied them over to /config with the appropriate changes to make all the params and overlays work.

Result

modelmesh-serving manifests can now be directly pulled by the operator from this repo itself, using the /config directory as the manifest source.

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VedantMahabaleshwarkar VedantMahabaleshwarkar changed the base branch from main to manifests_transition_v2 September 28, 2023 15:37
@VedantMahabaleshwarkar VedantMahabaleshwarkar marked this pull request as ready for review September 28, 2023 15:37
@VedantMahabaleshwarkar VedantMahabaleshwarkar merged commit d0e87f1 into opendatahub-io:manifests_transition_v2 Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant