Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knative-serving #266

Merged

Conversation

Jooho
Copy link

@Jooho Jooho commented Jan 16, 2024

chore: The purpose of this pull request is to addres this vulnerability.
In the Snyk report it says that the version 0.39.3 still affected, however it seems to be a false positive, since the fix can be found merged
as this commit shows.

Motivation

Modifications

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

Signed-off-by: jooho <jlee@redhat.com>
Copy link

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho
Copy link
Author

Jooho commented Jan 16, 2024

build issue will be fixed with upstream PR(kserve#478)

@Jooho
Copy link
Author

Jooho commented Jan 17, 2024

it turned out that the build issue only happened with release-0.11.1 so I created another PR (#268)

@Jooho
Copy link
Author

Jooho commented Jan 17, 2024

/retest

@Jooho Jooho added the lgtm label Jan 17, 2024
@Jooho Jooho self-assigned this Jan 17, 2024
Signed-off-by: Jooho Lee <jlee@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jan 17, 2024
Copy link

openshift-ci bot commented Jan 17, 2024

New changes are detected. LGTM label has been removed.

Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
@Jooho Jooho added the lgtm label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9b7af06 into opendatahub-io:release-0.11.1 Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants