Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotations for torch package on n-1 (2023b) version #573

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jun 18, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-8469

Description

Complementary PR for #572

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's it.

It is kind of strange and inconvenient that the package versions are defined in 2023b branch and the annotations for it are in main branch, but I understand why it's done this way, so ok.

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Jun 19, 2024

/override ci/prow/notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c93ff01 into opendatahub-io:main Jun 19, 2024
33 checks passed
@atheo89 atheo89 deleted the RHOAIENG-8469-is branch October 23, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants