Remove unused code in ArtifactDetails.spec.tsx (#3086)

Update tests and removed more unused code Removed disableS3Endpoint and disableArtifactsAPI flags
opendatahub-io · Aug 14, 2024 · a0f050f · a0f050f
1 parent 99adb80
commit a0f050f
Show file tree

Hide file tree

Showing 25 changed files with 102 additions and 852 deletions.
diff --git a/backend/src/routes/api/storage/index.ts b/backend/src/routes/api/storage/index.ts
diff --git a/backend/src/routes/api/storage/storageUtils.ts b/backend/src/routes/api/storage/storageUtils.ts
diff --git a/backend/src/types.ts b/backend/src/types.ts
@@ -37,8 +37,6 @@ export type DashboardConfig = K8sResourceCommon & {
       disableModelMesh: boolean;
       disableAcceleratorProfiles: boolean;
       disablePipelineExperiments: boolean;
-      disableS3Endpoint: boolean;
-      disableArtifactsAPI: boolean;
       disableDistributedWorkloads: boolean;
       disableModelRegistry: boolean;
       disableConnectionTypes: boolean;

diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts
@@ -62,8 +62,6 @@ export const blankDashboardCR: DashboardConfig = {
       disableModelMesh: false,
       disableAcceleratorProfiles: false,
       disablePipelineExperiments: false,
-      disableS3Endpoint: true,
-      disableArtifactsAPI: true,
       disableDistributedWorkloads: false,
       disableModelRegistry: true,
       disableConnectionTypes: true,

diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -63,8 +63,6 @@ spec:
     disableBiasMetrics: false
     disablePerformanceMetrics: false
     disablePipelineExperiments: true
-    disableS3Endpoint: true
-    disableArtifactsAPI: true
     disableDistributedWorkloads: false
     disableConnectionTypes: false
 ```
@@ -161,8 +159,6 @@ spec:
     disableBiasMetrics: false
     disablePerformanceMetrics: false
     disablePipelineExperiments: false
-    disableS3Endpoint: true
-    disableArtifactsAPI: true
   notebookController:
     enabled: true
     gpuSetting: autodetect

diff --git a/frontend/src/__mocks__/mlmd/mockGetArtifacts.ts b/frontend/src/__mocks__/mlmd/mockGetArtifacts.ts
@@ -8,7 +8,7 @@ export const mockedArtifactsResponse: GetArtifactsResponse = {
       id: 1,
       typeId: 14,
       type: 'system.Metrics',
-      uri: 's3://scalar-metrics-uri',
+      uri: 's3://scalar-metrics-uri-scalar-metrics-uri',
       properties: {},
       customProperties: {
         accuracy: { doubleValue: 92 },

diff --git a/frontend/src/__mocks__/mockDashboardConfig.ts b/frontend/src/__mocks__/mockDashboardConfig.ts
@@ -23,8 +23,6 @@ type MockDashboardConfigType = {
   disablePerformanceMetrics?: boolean;
   disableBiasMetrics?: boolean;
   disablePipelineExperiments?: boolean;
-  disableS3Endpoint?: boolean;
-  disableArtifactsAPI?: boolean;
   disableDistributedWorkloads?: boolean;
   disableModelRegistry?: boolean;
   disableConnectionTypes?: boolean;
@@ -54,8 +52,6 @@ export const mockDashboardConfig = ({
   disablePerformanceMetrics = false,
   disableBiasMetrics = false,
   disablePipelineExperiments = false,
-  disableS3Endpoint = true,
-  disableArtifactsAPI = true,
   disableDistributedWorkloads = false,
   disableModelRegistry = true,
   disableConnectionTypes = true,
@@ -162,8 +158,6 @@ export const mockDashboardConfig = ({
       disableModelMesh,
       disableAcceleratorProfiles,
       disablePipelineExperiments,
-      disableS3Endpoint,
-      disableArtifactsAPI,
       disableDistributedWorkloads,
       disableModelRegistry,
       disableConnectionTypes,

diff --git a/frontend/src/__tests__/cypress/cypress/support/commands/odh.ts b/frontend/src/__tests__/cypress/cypress/support/commands/odh.ts
@@ -572,26 +572,10 @@ declare global {
           type: 'GET /api/service/pipelines/:namespace/:serviceName/apis/v2beta1/artifacts/:artifactId',
           options: {
             query: { view: string };
-            path: { namespace: string; serviceName: string; artifactId: number };
+            path: { namespace: string; serviceName: string; artifactId: string };
           },
           response: OdhResponse<ArtifactStorage>,
         ) => Cypress.Chainable<null>) &
-        ((
-          type: 'GET /api/storage/:namespace',
-          options: {
-            query: { key: string; peek?: number };
-            path: { namespace: string };
-          },
-          response: OdhResponse<string>,
-        ) => Cypress.Chainable<null>) &
-        ((
-          type: 'GET /api/storage/:namespace/size',
-          options: {
-            query: { key: string };
-            path: { namespace: string };
-          },
-          response: OdhResponse<number>,
-        ) => Cypress.Chainable<null>) &
         ((
           type: 'GET /api/connection-types',
           response: ConnectionTypeConfigMap[],