Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-8414] Tracking of dashboard version in Segment. #2896

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

pilhuhn
Copy link
Contributor

@pilhuhn pilhuhn commented Jun 11, 2024

Description

Now that we have the dashboard version in the Frontend, we can send it to Segment as context.app.version
See RHOAIENG-8414

How Has This Been Tested?

Manual testing by looking at the network tab of the browser.

Test Impact

No functionality change of the UI code.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (b4db549) to head (0a80377).
Report is 139 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2896   +/-   ##
=======================================
  Coverage   78.64%   78.65%           
=======================================
  Files        1120     1120           
  Lines       23757    23757           
  Branches     5979     5979           
=======================================
+ Hits        18683    18685    +2     
+ Misses       5074     5072    -2     
Files Coverage Δ
frontend/src/utilities/segmentIOUtils.tsx 15.87% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4db549...0a80377. Read the comment docs.

@andrewballantyne
Copy link
Member

/hold

Please work with @jeff-phillips-18 to get this into a sprint and aligned on the Jira boards.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jun 12, 2024
@andrewballantyne andrewballantyne removed the do-not-merge/hold This PR is hold for some reason label Jul 3, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologizes, meant to approve this last week.

Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 94f83ad into opendatahub-io:main Jul 3, 2024
8 checks passed
@pilhuhn pilhuhn deleted the track-db-version branch October 8, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants