Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-2905] Pipeline Run Details tabs without content should be disabled #2919

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jun 17, 2024

Closes: RHOAIENG-2905

Description

All tabs associated with pipeline details that had conditions that led to tab content containing "no content" text are now disabled instead.

e.g.
image

Test Impact

Updated cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2905-pipline-run-detail-disable-tabs branch 2 times, most recently from 19bff62 to 4e89423 Compare June 18, 2024 13:15
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (2cafeff) to head (4e89423).
Report is 14 commits behind head on main.

Current head 4e89423 differs from pull request most recent head 42d1d8b

Please upload reports for the commit 42d1d8b to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
+ Coverage   78.49%   78.52%   +0.02%     
==========================================
  Files        1138     1138              
  Lines       24207    24160      -47     
  Branches     6155     6100      -55     
==========================================
- Hits        19002    18972      -30     
+ Misses       5205     5188      -17     
Files Coverage Δ
...Details/pipelineRun/PipelineRunDrawerRightTabs.tsx 95.45% <100.00%> (+0.71%) ⬆️
...Details/pipelineRun/SelectedNodeInputOutputTab.tsx 94.82% <ø> (+2.76%) ⬆️
...t/pipelinesDetails/pipelineRun/runLogs/LogsTab.tsx 68.00% <100.00%> (-0.79%) ⬇️

... and 96 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cafeff...42d1d8b. Read the comment docs.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Works fine.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-2905-pipline-run-detail-disable-tabs branch from 4e89423 to 42d1d8b Compare June 24, 2024 13:01
@openshift-ci openshift-ci bot removed the lgtm label Jun 24, 2024
@Gkrumbach07
Copy link
Member

cc @yannnz This was from an old jira to make these disabled, if you feel there should be another UX for no content let us know

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a9bbb1b into opendatahub-io:main Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants