-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-2905] Pipeline Run Details tabs without content should be disabled #2919
[RHOAIENG-2905] Pipeline Run Details tabs without content should be disabled #2919
Conversation
19bff62
to
4e89423
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 78.49% 78.52% +0.02%
==========================================
Files 1138 1138
Lines 24207 24160 -47
Branches 6155 6100 -55
==========================================
- Hits 19002 18972 -30
+ Misses 5205 5188 -17
... and 96 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm Works fine.
...d/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDrawerRightTabs.tsx
Outdated
Show resolved
Hide resolved
4e89423
to
42d1d8b
Compare
...d/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDrawerRightTabs.tsx
Show resolved
Hide resolved
...d/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDrawerRightTabs.tsx
Show resolved
Hide resolved
cc @yannnz This was from an old jira to make these disabled, if you feel there should be another UX for no content let us know /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-2905
Description
All tabs associated with pipeline details that had conditions that led to tab content containing "no content" text are now disabled instead.
e.g.
Test Impact
Updated cypress test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main