-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use artifact downloader hook in fetching markdown html #3053
Conversation
.../concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactVisualization.tsx
Outdated
Show resolved
Hide resolved
6f6cdaf
to
5446aae
Compare
The PR is been blocked due to browser running into |
added cypress test for compare runs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but why is the markdown not rendering anymore, html looks fine, but markdown is rendering as plain text @pnaik1 |
@Gkrumbach07 , I see iframe renders same way the browser does |
We talked about this and it is not possible right now without hitting cors to achieve this so i am approving /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-9738
Description
Updated the
useArtifactStorage
function to make it more stableUpdated the
manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
Updated the compare run section to use the new hook
useArtifactStorage
Updated the artifact nodes virtualization side drawer panel to use new hook
useArtifactStorage
How Has This Been Tested?
Update the crd ,check if disableArtifactsAPI is false the fetch is from the DSP server
when disableArtifactsAPI is true and disableS3Endpoint is false check the fetching occurs from backend
while running locally
open -n -a /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --args --user-data-dir="/tmp/chrome_dev_test" --disable-web-security
to avoid cors error4.Go to the created run page and click on the node, from the right side panel, click on the visualization tab, check the behaviour
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main