Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed disableS3Endpoint and disableArtifactsAPI flags #3086

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Removed disableS3Endpoint and disableArtifactsAPI flags #3086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 0 additions & 97 deletions backend/src/routes/api/storage/index.ts
View file
Open in desktop

This file was deleted.

197 changes: 0 additions & 197 deletions backend/src/routes/api/storage/storageUtils.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions backend/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ export type DashboardConfig = K8sResourceCommon & {
disableModelMesh: boolean;
disableAcceleratorProfiles: boolean;
disablePipelineExperiments: boolean;
disableS3Endpoint: boolean;
disableArtifactsAPI: boolean;
disableDistributedWorkloads: boolean;
disableModelRegistry: boolean;
disableConnectionTypes: boolean;
Expand Down
2 changes: 0 additions & 2 deletions backend/src/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ export const blankDashboardCR: DashboardConfig = {
disableModelMesh: false,
disableAcceleratorProfiles: false,
disablePipelineExperiments: false,
disableS3Endpoint: true,
disableArtifactsAPI: true,
disableDistributedWorkloads: false,
disableModelRegistry: true,
disableConnectionTypes: true,
Expand Down
4 changes: 0 additions & 4 deletions docs/dashboard-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ spec:
disableBiasMetrics: false
disablePerformanceMetrics: false
disablePipelineExperiments: true
disableS3Endpoint: true
disableArtifactsAPI: true
disableDistributedWorkloads: false
disableConnectionTypes: false
```
Expand Down Expand Up @@ -161,8 +159,6 @@ spec:
disableBiasMetrics: false
disablePerformanceMetrics: false
disablePipelineExperiments: false
disableS3Endpoint: true
disableArtifactsAPI: true
notebookController:
enabled: true
gpuSetting: autodetect
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/__mocks__/mlmd/mockGetArtifacts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const mockedArtifactsResponse: GetArtifactsResponse = {
id: 1,
typeId: 14,
type: 'system.Metrics',
uri: 's3://scalar-metrics-uri',
uri: 's3://scalar-metrics-uri-scalar-metrics-uri',
properties: {},
customProperties: {
accuracy: { doubleValue: 92 },
Expand Down
6 changes: 0 additions & 6 deletions frontend/src/__mocks__/mockDashboardConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ type MockDashboardConfigType = {
disablePerformanceMetrics?: boolean;
disableBiasMetrics?: boolean;
disablePipelineExperiments?: boolean;
disableS3Endpoint?: boolean;
disableArtifactsAPI?: boolean;
disableDistributedWorkloads?: boolean;
disableModelRegistry?: boolean;
disableConnectionTypes?: boolean;
Expand Down Expand Up @@ -54,8 +52,6 @@ export const mockDashboardConfig = ({
disablePerformanceMetrics = false,
disableBiasMetrics = false,
disablePipelineExperiments = false,
disableS3Endpoint = true,
disableArtifactsAPI = true,
disableDistributedWorkloads = false,
disableModelRegistry = true,
disableConnectionTypes = true,
Expand Down Expand Up @@ -162,8 +158,6 @@ export const mockDashboardConfig = ({
disableModelMesh,
disableAcceleratorProfiles,
disablePipelineExperiments,
disableS3Endpoint,
disableArtifactsAPI,
disableDistributedWorkloads,
disableModelRegistry,
disableConnectionTypes,
Expand Down
18 changes: 1 addition & 17 deletions frontend/src/__tests__/cypress/cypress/support/commands/odh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,26 +572,10 @@ declare global {
type: 'GET /api/service/pipelines/:namespace/:serviceName/apis/v2beta1/artifacts/:artifactId',
options: {
query: { view: string };
path: { namespace: string; serviceName: string; artifactId: number };
path: { namespace: string; serviceName: string; artifactId: string };
},
response: OdhResponse<ArtifactStorage>,
) => Cypress.Chainable<null>) &
((
type: 'GET /api/storage/:namespace',
options: {
query: { key: string; peek?: number };
path: { namespace: string };
},
response: OdhResponse<string>,
) => Cypress.Chainable<null>) &
((
type: 'GET /api/storage/:namespace/size',
options: {
query: { key: string };
path: { namespace: string };
},
response: OdhResponse<number>,
) => Cypress.Chainable<null>) &
((
type: 'GET /api/connection-types',
response: ConnectionTypeConfigMap[],
Expand Down
Loading
Loading