Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-11530] Add file field advanced settings for connection type fields #3132

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-11530

Description

Adds the field field advanced settings for connection type fields

How Has This Been Tested?

Tested manually. Added RTL tests.

Screen shots

image

image

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @simrandhaliw

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 69.64286% with 34 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (484b27f) to head (6b9c75c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../concepts/connectionTypes/fields/FileFormField.tsx 60.86% 18 Missing ⚠️
...onTypes/manage/advanced/FileUploadExtensionRow.tsx 60.86% 9 Missing ⚠️
...nage/advanced/FileUploadAdvancedPropertiesForm.tsx 86.66% 4 Missing ⚠️
...c/pages/connectionTypes/manage/manageFieldUtils.ts 71.42% 2 Missing ⚠️
...anage/advanced/DataFieldAdvancedPropertiesForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   85.19%   85.16%   -0.04%     
==========================================
  Files        1246     1250       +4     
  Lines       27166    27272     +106     
  Branches     7165     7209      +44     
==========================================
+ Hits        23145    23225      +80     
- Misses       4021     4047      +26     
Files with missing lines Coverage Δ
.../src/concepts/connectionTypes/fields/fieldUtils.ts 100.00% <100.00%> (ø)
frontend/src/concepts/connectionTypes/types.ts 100.00% <ø> (ø)
...ctionTypes/manage/ConnectionTypeDataFieldModal.tsx 86.48% <100.00%> (ø)
...anage/advanced/DataFieldAdvancedPropertiesForm.tsx 64.70% <0.00%> (-5.89%) ⬇️
...c/pages/connectionTypes/manage/manageFieldUtils.ts 71.42% <71.42%> (ø)
...nage/advanced/FileUploadAdvancedPropertiesForm.tsx 86.66% <86.66%> (ø)
...onTypes/manage/advanced/FileUploadExtensionRow.tsx 60.86% <60.86%> (ø)
.../concepts/connectionTypes/fields/FileFormField.tsx 58.62% <60.86%> (-3.29%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484b27f...6b9c75c. Read the comment docs.

@christianvogt
Copy link
Contributor

We shouldn't allow the user to save if there are duplicate extensions (case insensitive)

@jeff-phillips-18 jeff-phillips-18 force-pushed the file-field-advanced branch 3 times, most recently from 62f95cf to 82eec84 Compare August 29, 2024 22:07
Copy link
Contributor

@christianvogt christianvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't yet get a chance to test the latest changes because my cluster is hibernating.

@jeff-phillips-18 jeff-phillips-18 force-pushed the file-field-advanced branch 5 times, most recently from 45ed056 to d125e64 Compare August 30, 2024 16:46
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 18061ba into opendatahub-io:main Aug 30, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the file-field-advanced branch November 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants