-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-11530] Add file field advanced settings for connection type fields #3132
[RHOAIENG-11530] Add file field advanced settings for connection type fields #3132
Conversation
frontend/src/pages/connectionTypes/manage/advanced/FileUploadAdvancedPropertiesForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/FileUploadAdvancedPropertiesForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/FileUploadExtensionRow.tsx
Outdated
Show resolved
Hide resolved
We shouldn't allow the user to save if there are duplicate extensions (case insensitive) |
62f95cf
to
82eec84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't yet get a chance to test the latest changes because my cluster is hibernating.
frontend/src/pages/connectionTypes/manage/advanced/FileUploadAdvancedPropertiesForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/FileUploadAdvancedPropertiesForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/FileUploadExtensionRow.tsx
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/manage/advanced/FileUploadExtensionRow.tsx
Outdated
Show resolved
Hide resolved
45ed056
to
d125e64
Compare
d125e64
to
6b9c75c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes RHOAIENG-11530
Description
Adds the field field advanced settings for connection type fields
How Has This Been Tested?
Tested manually. Added RTL tests.
Screen shots
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
/cc @simrandhaliw