Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error text for duplicate label and value #3151

Conversation

emilys314
Copy link
Contributor

@emilys314 emilys314 commented Sep 3, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-10322

Description

Adds error text if there are duplicate entries for the labels and columns row.

The first entry will not have the error text, only the subsequent entries, which is similar to the file upload.

image

How Has This Been Tested?

Has been tested locally and jest unit tests have been added

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 3, 2024
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (57ce8a7) to head (f5d9eea).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   85.16%   85.16%   -0.01%     
==========================================
  Files        1251     1251              
  Lines       27384    27453      +69     
  Branches     7261     7292      +31     
==========================================
+ Hits        23322    23379      +57     
- Misses       4062     4074      +12     
Files with missing lines Coverage Δ
...manage/advanced/DropdownAdvancedPropertiesForm.tsx 88.70% <100.00%> (+4.26%) ⬆️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ce8a7...f5d9eea. Read the comment docs.

@emilys314 emilys314 marked this pull request as ready for review September 3, 2024 21:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 3, 2024
@jeff-phillips-18
Copy link
Contributor

The mocks show the error differently:

image

@emilys314
Copy link
Contributor Author

The mocks show the error differently:

Oops, just updated it
image

@christianvogt
Copy link
Contributor

/lgtm
/approve

works well to present the errors and prevent form submission

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c3700ce into opendatahub-io:main Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants