Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to connection type field modal #3164

Conversation

emilys314
Copy link
Contributor

@emilys314 emilys314 commented Sep 6, 2024

closes https://issues.redhat.com/browse/RHOAIENG-12568

Description

  • Auto selects the name field
  • update labels that no longer have "field"
  • "Text - Short" is auto selected
  • field type dropdown no longer has focused styling
  • button is now "Save" and not "Edit"

Initial load render screenshot:
image
image

How Has This Been Tested?

Locally, mainly visual changes

Test Impact

The field labels have been changed so the test-id's could also be updated, but I haven't (they still have "field")

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 6, 2024
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (d786249) to head (82a7a28).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
+ Coverage   85.19%   85.29%   +0.09%     
==========================================
  Files        1253     1258       +5     
  Lines       27539    27677     +138     
  Branches     7335     7372      +37     
==========================================
+ Hits        23463    23607     +144     
+ Misses       4076     4070       -6     
Files with missing lines Coverage Δ
...ctionTypes/manage/ConnectionTypeDataFieldModal.tsx 84.93% <100.00%> (-1.56%) ⬇️
...onnectionTypes/manage/ConnectionTypeFieldModal.tsx 25.00% <ø> (ø)
...nectionTypes/manage/ConnectionTypeSectionModal.tsx 100.00% <100.00%> (+26.31%) ⬆️
...onTypes/manage/ManageConnectionTypeFieldsTable.tsx 59.25% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d786249...82a7a28. Read the comment docs.

@emilys314 emilys314 marked this pull request as ready for review September 6, 2024 19:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 6, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4bfade5 into opendatahub-io:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants