-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to connection type field modal #3164
Fixes to connection type field modal #3164
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
+ Coverage 85.19% 85.29% +0.09%
==========================================
Files 1253 1258 +5
Lines 27539 27677 +138
Branches 7335 7372 +37
==========================================
+ Hits 23463 23607 +144
+ Misses 4076 4070 -6
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/pages/connectionTypes/manage/ConnectionTypeDataFieldModal.tsx
Outdated
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes https://issues.redhat.com/browse/RHOAIENG-12568
Description
Initial load render screenshot:
How Has This Been Tested?
Locally, mainly visual changes
Test Impact
The field labels have been changed so the test-id's could also be updated, but I haven't (they still have "field")
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main