-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change pagination to compact style for all pipeline tables #3178
Change pagination to compact style for all pipeline tables #3178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
==========================================
+ Coverage 85.27% 85.28% +0.01%
==========================================
Files 1258 1258
Lines 27689 27689
Branches 7372 7372
==========================================
+ Hits 23612 23615 +3
+ Misses 4077 4074 -3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Global pipelineTable should also be compact https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/pipelines/global/pipelines/PipelinesView.tsx |
@pnaik1 it looks like it is. you may be thinking of compact rows. I tested it live and looks like all tables are compact pagination /lgtm |
oops yeah I was thinking of row compact :( |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
niubi |
JIRA: https://issues.redhat.com/browse/RHOAIENG-11428
(This should also fixes https://issues.redhat.com/browse/RHOAIENG-11383)
Description
Change pagination to compact style at 3 tables.
Experiments table:
Pipeline schedules table:
Compare run ROC curve table:
This should cover all the tables in the pipeline area
How Has This Been Tested?
Check all the pages in the pipelines and experiments area and make sure all the paginations are in the compact style.
Test Impact
Modify the cypress tests because some paginations don't have the page number input anymore.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main