Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pagination to compact style for all pipeline tables #3178

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 9, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-11428
(This should also fixes https://issues.redhat.com/browse/RHOAIENG-11383)

Description

Change pagination to compact style at 3 tables.

Experiments table:

Screenshot 2024-09-09 at 5 54 48 PM

Pipeline schedules table:

Screenshot 2024-09-09 at 5 55 27 PM

Compare run ROC curve table:

Screenshot 2024-09-09 at 5 55 52 PM

This should cover all the tables in the pipeline area

How Has This Been Tested?

Check all the pages in the pipelines and experiments area and make sure all the paginations are in the compact style.

Test Impact

Modify the cypress tests because some paginations don't have the page number input anymore.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (aa3ef61) to head (147fdb6).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
+ Coverage   85.27%   85.28%   +0.01%     
==========================================
  Files        1258     1258              
  Lines       27689    27689              
  Branches     7372     7372              
==========================================
+ Hits        23612    23615       +3     
+ Misses       4077     4074       -3     
Files with missing lines Coverage Δ
...t/compareRuns/metricsSection/roc/RocCurveTable.tsx 100.00% <ø> (ø)
.../content/tables/experiment/ExperimentTableBase.tsx 88.88% <ø> (ø)
...pipelineRecurringRun/PipelineRecurringRunTable.tsx 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3ef61...147fdb6. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 10, 2024

@DaoDaoNoCode
Copy link
Member Author

DaoDaoNoCode commented Sep 10, 2024

@Gkrumbach07
Copy link
Member

@pnaik1 it looks like it is. you may be thinking of compact rows.

I tested it live and looks like all tables are compact pagination

/lgtm

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 12, 2024

oops yeah I was thinking of row compact :(
Retested
/lgtm

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f5037ea into opendatahub-io:main Sep 12, 2024
8 checks passed
@YanshanSong
Copy link

niubi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants