-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update empty state of versions list and models lists #3277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3277 +/- ##
==========================================
- Coverage 85.06% 84.87% -0.19%
==========================================
Files 1293 1306 +13
Lines 28846 29204 +358
Branches 7759 7889 +130
==========================================
+ Hits 24538 24788 +250
- Misses 4308 4416 +108
... and 112 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
"View archived models" and "View archived versions" secondary action links are only visible when there are archived models and archived versions respectively.
/lgtm Verified locally, looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ppadti
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-12863
Description
This PR aims to update the empty state of versions list and models list to show the secondary action only when there are archived versions / archived models.
How Has This Been Tested?
Check for empty state of versions list with no archived versions.
Check for empty state of models list with no archived models.
Test Impact
NA, just rendering the empty state actions conditionally.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main