Fix Prometheus PVC Fill Status Call (for basic users)

[andrewballantyne]

Resolves: #862

Description

Using the wrong port for simple metrics the user can get.

• Port 9091 is for users who can see all metrics in the cluster (get namespace permission)
• Port 9092 is for users who can only get metrics in certain namespaces

How Has This Been Tested?

• Turn down the ODH operator on your cluster
• Replace the ODH Dashboard container's image with the one from the PR
• Log into the Dashboard with your basic user
• Create a project & workbench -- then view the status of the PVC

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[DaoDaoNoCode]

lgtm

[DaoDaoNoCode]

Could you also add ${port} to the end of this host https://github.com/opendatahub-io/odh-dashboard/blob/main/backend/src/utils/prometheusUtils.ts#L89? I just noticed that we didn't use the port in the DEV_MODE so the result will be different when testing locally and remotely because they are using a different port if we don't assign it.

[andrewballantyne]

Could you also add ${port} to the end of this host https://github.com/opendatahub-io/odh-dashboard/blob/main/backend/src/utils/prometheusUtils.ts#L89? I just noticed that we didn't use the port in the DEV_MODE so the result will be different when testing locally and remotely because they are using a different port if we don't assign it.

Pretty sure this doesn't work -- I just tested adding :${port} on the end and it looks like there is an error 500.

    return `https://${instanceName}-${namespace}.apps.${namedHost}:${port}`;

This errors out.

I think because it's a direct api request, this is not going to work.

My logs:

>> [2023-02-17 14:48:24.020 +0000] INFO (6374 on Andrews-MacBook-Pro): Making Prometheus call: https://thanos-querier-openshift-monitoring.apps.{cluster-name}.devcluster.openshift.com:9092/api/v1/query?namespace=andrews-test&query=kubelet_volume_stats_used_bytes{persistentvolumeclaim='solar-predictions'}
...
>> [2023-02-17 14:48:30.523 +0000] ERROR (6374 on Andrews-MacBook-Pro): Failure calling Prometheus. connect ETIMEDOUT {some-ip}:9092

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment