-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PF and get rid of custom CSS on settings page #952
Upgrade PF and get rid of custom CSS on settings page #952
Conversation
Holding to prevent merging in this release -- this is for next release. |
Verified #977 is fixed by bumping the PF version. |
086bf3e
to
ade606f
Compare
ade606f
to
dce8bed
Compare
Not related to the PR itself but found testing it, inside return (
<Tbody key={image.name} isExpanded={isBYONImageExpanded(image)}>
<Tr isHidden={applyTableFilter(image)}>
<Td Will trigger the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#952) * Upgrade PF and get rid of custom CSS on settings page * fix lint error * add aria label to multi selection * address comments and small bug fix
…#952) * Upgrade PF and get rid of custom CSS on settings page * fix lint error * add aria label to multi selection * address comments and small bug fix
…#952) * Upgrade PF and get rid of custom CSS on settings page * fix lint error * add aria label to multi selection * address comments and small bug fix
Description
Closes #950
Because PF changed the
onChange
prop order forSearchInput
to match the DOM event (event as the first parameter and value as the second), we also need to make some small updates to match that change.Also, update the user management page and cluster settings page, get rid of the Form component, and use the plain bordered Card component instead to get rid of the custom CSS styles.
How Has This Been Tested?
The visual styles are slightly changed on the settings page, so go to the settings page to manually see if anything looks weird. The functionalities keep the same.
Merge criteria: