Make sure nonexistent user group not change the permission of current admin permission #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… admin permission
|
/hold Waiting for an image built to deploy on the cluster to test. |
|
Verified, I can still see the settings as an RHODS admin (not cluster admin) and the error will prompt properly. |
|
/unhold |
andrewballantyne
approved these changes
Mar 9, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lucferbux
pushed a commit
to lucferbux/odh-dashboard
that referenced
this pull request
Mar 13, 2023
bartoszmajsak
pushed a commit
to maistra/odh-dashboard
that referenced
this pull request
Mar 30, 2023
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #878
The reason is when a group is not found, an error will be thrown, which will break the whole check access loop. If we put the try-catch block inside the loop, the problem will be fixed.
How Has This Been Tested?
See the instructions in the issue, the same way to test it.
Merge criteria: