Improve frontend lint settings

frontend/.eslintrc

@@ -54,6 +54,7 @@
     "no-restricted-imports": ["error", {
       "patterns": ["*/**", "!~/**", "!./**", "!@*/**", "!react*/**"]
     }],
+    "no-console": "error",
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/interface-name-prefix": "off",
     "@typescript-eslint/no-var-requires": "off",

frontend/src/app/HeaderTools.tsx

@@ -37,6 +37,7 @@ const HeaderTools: React.FC<HeaderToolsProps> = ({ onNotificationsClick }) => {
   const handleLogout = () => {
     setUserMenuOpen(false);
     logout().then(() => {
+      /* eslint-disable-next-line no-console */
       console.log('logged out');
       window.location.reload();
     });

frontend/src/app/appUtils.ts

@@ -1,2 +1,3 @@
 export const logout = (): Promise<unknown> =>
+  /* eslint-disable-next-line no-console */
   fetch('/oauth/sign_out').catch((err) => console.error('Error logging out', err));

frontend/src/app/useApplicationSettings.tsx

@@ -32,6 +32,7 @@ export const useApplicationSettings = (): {
           if (e?.message?.includes('Error getting Oauth Info for user')) {
             // NOTE: this endpoint only requests oauth because of the security layer, this is not an ironclad use-case
             // Something went wrong on the server with the Oauth, let us just log them out and refresh for them
+            /* eslint-disable-next-line no-console */
             console.error(
               'Something went wrong with the oauth token, please log out...',
               e.message,

frontend/src/app/useTimeBasedRefresh.ts

@@ -24,6 +24,7 @@ const useTimeBasedRefresh = (): SetTime => {
     const lastDate = new Date(ref.current.lastRefreshTimestamp);
     const setNewDateString = ref.current.setLastRefreshTimestamp;
 
+    /* eslint-disable no-console */
     // Print into the console in case we are not refreshing or the browser has preserve log enabled
     console.warn('Attempting to re-trigger an auto refresh');
     console.log('Last refresh was on:', lastDate);
@@ -39,6 +40,7 @@ const useTimeBasedRefresh = (): SetTime => {
         `We should have refreshed but it appears the last time we auto-refreshed was less than an hour ago. '${KEY_NAME}' session storage setting can be cleared for this to refresh again within the hour from the last refresh.`,
       );
     }
+    /* eslint-enable no-console */
   }, []);
 };
 

frontend/src/components/browserStorage/BrowserStorageContext.tsx

@@ -40,6 +40,7 @@ export const useBrowserStorage = <T,>(
         setStringValue(storageKey, value, isSessionStorage);
         return true;
       }
+      /* eslint-disable-next-line no-console */
       console.error('Was not a string value provided, cannot stringify');
       return false;
     },
@@ -96,6 +97,7 @@ export const BrowserStorageContextProvider: React.FC<BrowserStorageContextProvid
         try {
           return JSON.parse(value);
         } catch (e) {
+          /* eslint-disable-next-line no-console */
           console.warn(`Failed to parse storage value "${key}"`);
           return null;
         }
@@ -115,6 +117,7 @@ export const BrowserStorageContextProvider: React.FC<BrowserStorageContextProvid
 
         return true;
       } catch (e) {
+        /* eslint-disable-next-line no-console */
         console.warn(
           'Could not store a value because it was requested to be stringified but was an invalid value for stringification.',
         );

frontend/src/pages/notebookController/NotebookLogoutRedirect.tsx

@@ -36,6 +36,7 @@ const NotebookLogoutRedirect: React.FC = () => {
           if (cancelled) {
             return;
           }
+          /* eslint-disable-next-line no-console */
           console.error(e);
         });
     }

frontend/src/pages/notebookController/screens/server/SpawnerPage.tsx

@@ -156,6 +156,7 @@ const SpawnerPage: React.FC = () => {
         setVariableRows([...fetchedVariableRowsConfigMap, ...fetchedVariableRowsSecret]);
       }
     };
+    /* eslint-disable-next-line no-console */
     mapEnvironmentVariableRows().catch((e) => console.error(e));
     return () => {
       cancelled = true;
@@ -335,6 +336,7 @@ const SpawnerPage: React.FC = () => {
                   handleNotebookAction().catch((e) => {
                     setCreateInProgress(false);
                     hideStartShown();
+                    /* eslint-disable-next-line no-console */
                     console.error('Error submitting resources around starting a notebook', e);
                     setSubmitError(e);
                   });

frontend/src/pages/notebookController/screens/server/useGPUSetting.ts

@@ -72,7 +72,6 @@ const useGPUSetting = (
       setFetching(false);
       setAreGpusAvailable(false);
       setGpuSize(0);
-      console.error(e);
       notification.error('Failed to fetch GPU', e.message);
     };
 

frontend/src/pages/notebookController/screens/server/useSpawnerNotebookModalState.ts

@@ -49,6 +49,7 @@ const useSpawnerNotebookModalState = (
           if (!createInProgress) {
             // We are not creating, make sure the Notebook is stopped
             stopNotebook().catch(() => {
+              /* eslint-disable-next-line no-console */
               console.error('Failed to stop notebook on refresh');
             });
           } else {

frontend/src/pages/projects/notebook/ListNotebookState.tsx

@@ -39,6 +39,7 @@ const ListNotebookState: React.FC<ListNotebookStateProps> = ({
       case 'status':
         return <NotebookStatusToggle notebookState={state} doListen />;
       default:
+        /* eslint-disable-next-line no-console */
         console.error('Unknown show type', show);
         return <>-</>;
     }

frontend/src/pages/projects/notebook/useRefreshNotebookUntilStart.ts

@@ -17,6 +17,7 @@ const useRefreshNotebookUntilStart = (
         const { isRunning, refresh } = lastNotebookState.current;
         if (!isRunning) {
           refresh().catch((e) => {
+            /* eslint-disable-next-line no-console */
             console.error('Error refreshing, stopping notebook refresh', e);
             setWatchingForNotebook(false);
           });

frontend/src/pages/projects/notebook/useWatchNotebookEvents.ts

@@ -30,6 +30,7 @@ export const useWatchNotebookEvents = (
               setNoteBookEvents(data);
             })
             .catch((e) => {
+              /* eslint-disable-next-line no-console */
               console.error('Error fetching notebook events', e);
               clear();
             });

frontend/src/pages/projects/screens/projects/ProjectTable.tsx

@@ -70,6 +70,7 @@ const ProjectTable: React.FC<ProjectTableProps> = ({
 
           refreshProjects()
             .then(() => setRefreshIds((ids) => ids.filter((id) => id !== refreshId)))
+            /* eslint-disable-next-line no-console */
             .catch((e) => console.error('Failed refresh', e));
         }}
         editProjectData={editData}
@@ -79,6 +80,7 @@ const ProjectTable: React.FC<ProjectTableProps> = ({
         onClose={(deleted) => {
           setDeleteData(undefined);
           if (deleted) {
+            /* eslint-disable-next-line no-console */
             refreshProjects().catch((e) => console.error('Failed refresh', e));
           }
         }}

frontend/src/pages/projects/screens/spawner/environmentVariables/useNotebookEnvVariables.tsx

@@ -64,6 +64,7 @@ export const useNotebookEnvVariables = (
     if (notebook) {
       fetchNotebookEnvVariables(notebook)
         .then((envVars) => setEnvVariables(envVars))
+        /* eslint-disable-next-line no-console */
         .catch((e) => console.error('Reading environment variables failed: ', e));
     }
   }, [notebook]);

frontend/src/pages/projects/screens/spawner/service.ts

@@ -176,6 +176,7 @@ export const createConfigMapsAndSecretsForNotebook = async (
   return Promise.all(creatingPromises)
     .then((results: (ConfigMapKind | SecretKind)[]) => getEnvFromList(results, []))
     .catch((e) => {
+      /* eslint-disable-next-line no-console */
       console.error('Creating environment variables failed: ', e);
       throw e;
     });

frontend/src/pages/projects/screens/spawner/spawnerUtils.ts

@@ -150,6 +150,7 @@ export const getImageVersionDependencies = (
   } catch (e) {
     if (depString.includes('[')) {
       // It was intended to be an array but failed to parse, log the error
+      /* eslint-disable-next-line no-console */
       console.error(`JSON parse error when parsing ${imageVersion.name}`);
     }
     dependencies = [];

frontend/src/pages/projects/screens/spawner/storage/useNotebookRootStorage.ts

@@ -13,6 +13,7 @@ const useNotebookRootStorage = (notebook?: NotebookKind): PersistentVolumeClaimK
         (volumeMount) => volumeMount.mountPath === ROOT_MOUNT_PATH,
       );
       if (!volumeMount) {
+        /* eslint-disable-next-line no-console */
         console.error('No storage mounted on root path');
         setPvc(undefined);
       } else {

frontend/src/services/notebookService.ts

@@ -26,7 +26,7 @@ export const getNotebookAndStatus = (
       if (e.response.status === 404) {
         return { notebook, isRunning: false };
       }
-
+      /* eslint-disable-next-line no-console */
       console.error(
         'Checking notebook status failed, falling back on notebook check logic',
         e.response.data.message,

frontend/src/utilities/notebookControllerUtils.ts

@@ -113,6 +113,7 @@ export const getNotebookControllerUserState = (
     if (usernameTranslate(loggedInUser) === notebookLabelUser) {
       user = loggedInUser;
     } else {
+      /* eslint-disable-next-line no-console */
       console.error('Could not get full user data');
       return null;
     }
@@ -203,6 +204,7 @@ export const useNotebookRedirectLink = (): (() => Promise<string>) => {
     if (!routeName) {
       // At time of call, if we do not have a route name, we are too late
       // This should *never* happen, somehow the modal got here before the Notebook had a name!?
+      /* eslint-disable-next-line no-console */
       console.error('Unable to determine why there was no route -- notebook did not have a name');
       return Promise.reject();
     }
@@ -218,6 +220,7 @@ export const useNotebookRedirectLink = (): (() => Promise<string>) => {
               resolve(backupRoute);
               return;
             }
+            /* eslint-disable-next-line no-console */
             console.warn('Unable to get the route. Re-polling.', e);
             if (fetchCountRef.current <= 0) {
               fetchCountRef.current--;
@@ -229,6 +232,7 @@ export const useNotebookRedirectLink = (): (() => Promise<string>) => {
       };
 
       call(resolve, () => {
+        /* eslint-disable-next-line no-console */
         console.error(
           'Could not fetch route over several tries, See previous warnings for a history of why each failed call.',
         );

frontend/src/utilities/segmentIOUtils.tsx

@@ -7,6 +7,7 @@ export const fireTrackingEvent = (
 ): void => {
   const clusterID = window.clusterID ?? '';
   if (DEV_MODE) {
+    /* eslint-disable-next-line no-console */
     console.log(
       `Telemetry event triggered: ${eventType}${
         properties ? ` - ${JSON.stringify(properties)}` : ''
@@ -36,6 +37,7 @@ export const initSegment = async (props) => {
     return;
   }
   if (analytics.invoked) {
+    /* eslint-disable-next-line no-console */
     window.console && console.error && console.error('Segment snippet included twice.');
   } else {
     analytics.invoked = true;