Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow duplicated model name in different projects on global serving page #985

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Allow duplicated model name in different projects on global serving page #985

merged 1 commit into from
Mar 3, 2023

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Mar 2, 2023 •
edited
Loading

Description

Closes #968

How Has This Been Tested?

  1. Create two data science projects
  2. In each project, deploy a model with the same name
  3. Go to the global model serving page
  4. Check if both of the models are shown on the table

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

lucferbux
lucferbux approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, now seeing the issue it's so obvious.

@openshift-ci openshift-ci bot added the lgtm label Mar 2, 2023
andrewballantyne
andrewballantyne approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution. 👍

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit ef3c405 into opendatahub-io:main Mar 3, 2023
lucferbux pushed a commit to lucferbux/odh-dashboard that referenced this pull request Mar 13, 2023
@DaoDaoNoCode @lucferbux
Allow duplicated model name in different projects on global serving p…
42e08fd 
…age (opendatahub-io#985)
bartoszmajsak pushed a commit to maistra/odh-dashboard that referenced this pull request Mar 30, 2023
@DaoDaoNoCode @bartoszmajsak
Allow duplicated model name in different projects on global serving p…
5b8b262 
…age (opendatahub-io#985)
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
@DaoDaoNoCode @strangiato
Allow duplicated model name in different projects on global serving p…
ae01e92 
…age (opendatahub-io#985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucferbux lucferbux lucferbux approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@Gkrumbach07 Gkrumbach07 Awaiting requested review from Gkrumbach07

Assignees

@andrewballantyne andrewballantyne

@lucferbux lucferbux

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Global Model Serving Page Excludes Duplicate Names
4 participants
@DaoDaoNoCode @andrewballantyne @lucferbux @openshift-merge-robot