-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Clean up logfile for dev starts #987
[Dev] Clean up logfile for dev starts #987
Conversation
would you want the same cleaning to run on frontend as well. And even the root folder has some logs? |
Logs are generated by the backend -- see the PR I mentioned in the description. https://github.com/opendatahub-io/odh-dashboard/pull/914/files#diff-489e4ec44d1b710d94129fd9004a2d41bbae615dbc8e9ea3e9b2c6513a3c0accR50 No sense in cleaning it from the frontend -- as it can't write to the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cleans up the log file introduced in #914
Every time we start our dev environment is a good time to clean up the logfile. If we don't, it grows indefinitely. I hit over 5mb recently... it likely will grow indefinitely as there is no cleanup mechanism.
This is by design for production, but for development it's unnecessary.