Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a11y issues in data connections modal and deploy models modal #994

Merged
merged 4 commits into from
Mar 9, 2023
Merged

fix a11y issues in data connections modal and deploy models modal #994

merged 4 commits into from
Mar 9, 2023

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Mar 6, 2023 •
edited
Loading

Do not merge/review, needs rebase
Towards #965

Description

Delete data connections modal - before:
Screen Shot 2023-03-06 at 4 57 20 PM

Delete data connections modal - after:
Screen Shot 2023-03-06 at 5 12 56 PM

Configure model server modal - before:
Screen Shot 2023-03-06 at 5 04 26 PM

Configure model server modal - after:
Screen Shot 2023-03-06 at 5 31 49 PM

Deploy model modal - before:
Screen Shot 2023-03-09 at 10 55 34 AM
Screen Shot 2023-03-09 at 10 54 06 AM

Deploy model modal - after:
Screen Shot 2023-03-09 at 10 57 21 AM
Screen Shot 2023-03-09 at 10 54 23 AM

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

lucferbux
lucferbux reviewed Mar 7, 2023
View reviewed changes
frontend/src/pages/projects/screens/projects/EmptyProjects.tsx Outdated
@@ -27,6 +27,7 @@ const EmptyProjects: React.FC = () => {
<EmptyStateSecondaryActions>
<Button
href="/notebookController"
component="a"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So every button dedicated to navigation should have the component prop to a hyperlink right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless there is a <Link ... /> component inside the button. In that case i dont think you need component='a'

@jenny-s51 please confirm if this is the case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct @Gkrumbach07 - reverted in fbad401

frontend/src/pages/projects/screens/detail/DetailsSection.tsx Outdated Show resolved Hide resolved
Gkrumbach07
Gkrumbach07 reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. I think there are some resolutions we made in other PRs that apply in this PR

frontend/src/pages/projects/screens/detail/DetailsSection.tsx Outdated Show resolved Hide resolved
frontend/src/pages/projects/screens/projects/EmptyProjects.tsx Outdated
@@ -27,6 +27,7 @@ const EmptyProjects: React.FC = () => {
<EmptyStateSecondaryActions>
<Button
href="/notebookController"
component="a"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless there is a <Link ... /> component inside the button. In that case i dont think you need component='a'

@jenny-s51 please confirm if this is the case

frontend/src/pages/projects/screens/projects/ManageProjectModal.tsx Outdated Show resolved Hide resolved
@jenny-s51 jenny-s51 added the a11y Accessibility (a11y) related issues label Mar 7, 2023
Gkrumbach07
Gkrumbach07 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table changes are inline with the other PR. Everything looks good to me. And I think the last of the comments are resolved (or can be resolved imo).

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2023
@openshift-ci openshift-ci bot removed the lgtm label Mar 8, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 8, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Mar 8, 2023
lucferbux
lucferbux approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Changes seem fine now

@openshift-ci openshift-ci bot added the lgtm label Mar 9, 2023
@openshift-ci openshift-ci bot removed the lgtm label Mar 9, 2023
andrewballantyne
andrewballantyne requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we still have a couple issues
image

@openshift-ci openshift-ci bot added the lgtm label Mar 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, Gkrumbach07, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit a14965a into opendatahub-io:main Mar 9, 2023
lucferbux pushed a commit to lucferbux/odh-dashboard that referenced this pull request Mar 13, 2023
@jenny-s51 @lucferbux
fix a11y issues in data connections modal and deploy models modal (op…
52d258b 
…endatahub-io#994)

* fix data connections and models modal

PR feedback

* Update EmptyProjects.tsx

* fix block error

* fix last few a11y errors
bartoszmajsak pushed a commit to maistra/odh-dashboard that referenced this pull request Mar 30, 2023
@jenny-s51 @bartoszmajsak
fix a11y issues in data connections modal and deploy models modal (op…
59bc0a5 
…endatahub-io#994)

* fix data connections and models modal

PR feedback

* Update EmptyProjects.tsx

* fix block error

* fix last few a11y errors
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
@jenny-s51 @strangiato
fix a11y issues in data connections modal and deploy models modal (op…
b8dd1a2 
…endatahub-io#994)

* fix data connections and models modal

PR feedback

* Update EmptyProjects.tsx

* fix block error

* fix last few a11y errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaoDaoNoCode DaoDaoNoCode DaoDaoNoCode left review comments

@lucferbux lucferbux lucferbux approved these changes

@Gkrumbach07 Gkrumbach07 Gkrumbach07 approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

Assignees

@andrewballantyne andrewballantyne

@Gkrumbach07 Gkrumbach07

@lucferbux lucferbux

Labels
a11y Accessibility (a11y) related issues approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jenny-s51 @andrewballantyne @Gkrumbach07 @lucferbux @DaoDaoNoCode @openshift-merge-robot