Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Model Metrics #999

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Mar 9, 2023

Closes: #998

Description

Disable model metrics by using the hook to control if it's enabled or not and always set it to false.

How Has This Been Tested?

  • Model Serving Global Page => Model Table (link on the name)
  • DS Projects => Model Serving Runtime Models => Model Table (link on the name)

Before
Screenshot 2023-03-09 at 3 57 50 PM
Screenshot 2023-03-09 at 3 58 07 PM

After
Screenshot 2023-03-09 at 3 59 00 PM
Screenshot 2023-03-09 at 3 59 17 PM

Test Impact

Not to be tested at this time.

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@andrewballantyne
Copy link
Member Author

cc @kywalker-rh / @vconzola / @jedemo

@andrewballantyne
Copy link
Member Author

andrewballantyne commented Mar 9, 2023

Cherrypicked to a branch v2.7.0-fixes off of the tag v2.7.0. Will do a z-stream release shortly after this to indicate the removal of Model Metrics in ODH. Turns out doing a release off of a non-PR cherrypick is very awkward. Will just do the release tomorrow with it. v2.8.0 will remove Model Metrics.

@vconzola
Copy link

vconzola commented Mar 9, 2023

LGTM.

@Gkrumbach07
Copy link
Member

just forcing disabled state.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member Author

Disabling for main and to-be v2.8.0

@openshift-merge-robot openshift-merge-robot merged commit aafdd6a into opendatahub-io:main Mar 9, 2023
lucferbux pushed a commit to lucferbux/odh-dashboard that referenced this pull request Mar 13, 2023
bartoszmajsak pushed a commit to maistra/odh-dashboard that referenced this pull request Mar 30, 2023
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
@andrewballantyne andrewballantyne deleted the disable-model-metrics branch June 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Model Metrics
4 participants