Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Added subscription permission for dashboard memory/cpu fix. #555

Merged

Conversation

cfchase
Copy link
Member

@cfchase cfchase commented Apr 13, 2022

@LaVLaS
Copy link
Contributor

LaVLaS commented Apr 13, 2022

@cfchase Are you going to include the dashboard version update with this fix?

@crobby
Copy link
Contributor

crobby commented Apr 25, 2022

Is this change still WIP, or can that be removed

@cfchase cfchase changed the title WIP - Added subscription permission for dashboard memory/cpu fix. Added subscription permission for dashboard memory/cpu fix. Apr 26, 2022
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This does not resolve any issues in the current odh-manifests deployment of the v1.0 dashboard and is a planned update for the upcoming dashboard v2.0 release

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfchase, crobby, jeff-phillips-18, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 674b4c9 into opendatahub-io:master Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants