Add dashboard config CRD #561
Conversation
maroroman
force-pushed
the
dashboard/cr-config
branch
2 times, most recently
from
b15eced
to
ab0917f
Compare
|
@anishasthana @VaishnaviHire This CR has a problem that it would be reconciled by the operator, I am considering creating it in a init container of the dashboard when it is deployed to work around it, but let me know what would be the best solution. At the very least the notebook status needs to be updated on every action in the spawner UI |
maroroman
force-pushed
the
dashboard/cr-config
branch
from
ab0917f
to
2a878f5
Compare
|
@maroroman @dlabaj Will this be supported in the dashboard v2.0 release? If not, then we should put this on hold until it is included in a planned release |
maroroman
force-pushed
the
dashboard/cr-config
branch
3 times, most recently
from
993561f
to
d0670e3
Compare
maroroman
force-pushed
the
dashboard/cr-config
branch
2 times, most recently
from
013c288
to
81eac68
Compare
|
/hold Putting this on hold until opendatahub-io/odh-dashboard#238 is finalized and merged |
openshift-ci
bot
added
the
do-not-merge/hold
maroroman
force-pushed
the
dashboard/cr-config
branch
from
6e352e2
to
52960ae
Compare
maroroman
force-pushed
the
dashboard/cr-config
branch
from
52960ae
to
ffd2f66
Compare
|
/unhold This is required for the Dashboard v2.0 release |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
maroroman
force-pushed
the
dashboard/cr-config
branch
from
ffd2f66
to
002b9c6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlabaj, LaVLaS, lucferbux, maroroman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a odh-dashboard custom resource definition (and a default instance). Currently it replaces the values in the Dashboard configmap and adds notebook sizes, notebook controller configuration and notebook controller status.
The notebook controller part of the CR is supposed to essentially fill the role of the Jupyterhub Singleuser Profiles configmap, but for the Notebook controller.
The notebook controller status should be an array with the information about the user's previous choices and environment variables and a link to their envVar secrets (managed by the spawner UI)
Note: I do not know whether to also add other parts of the old JSP configmap, such as gpuTypes and profiles, although these can be added in together with the features that use them.
Related to: opendatahub-io/odh-dashboard#159