Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

ODH Notebook Controller: Enable culling #581

Merged
merged 1 commit into from
Jul 5, 2022
Merged

ODH Notebook Controller: Enable culling #581

merged 1 commit into from
Jul 5, 2022

Conversation

samuelvl
Copy link
Contributor

@samuelvl samuelvl commented Jun 29, 2022

This PR includes the following changes:

  • Update notebook controller version.
  • Add instructions about how to enable culling.
  • Expose the testing notebooks in a culling compatible path.

@samuelvl
Copy link
Contributor Author

/wip

@samuelvl samuelvl changed the title [WIP] ODH Notebook Controller: Enable culling ODH Notebook Controller: Enable culling Jun 30, 2022
@samuelvl
Copy link
Contributor Author

samuelvl commented Jul 4, 2022

@VaishnaviHire @LaVLaS It's ready to be reviewed

@samuelvl samuelvl self-assigned this Jul 4, 2022
Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Culling worked for me with the test steps provided

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS, samuelvl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants