Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update failing tests #615

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

strangiato
Copy link
Contributor

Description

Tests are currently failing with the following errors:

==============================================================================
Test-Odh-Jupyterlab-Notebook                                                  
==============================================================================
Can Launch Jupyterhub                                                 | FAIL |
SessionNotCreatedException: Message: session not created: This version of ChromeDriver only supports Chrome version 102
Current browser version is 104.0.5112.79 with binary path /usr/bin/google-chrome
------------------------------------------------------------------------------
Can Login to Jupyterhub                                               | FAIL |
No browser is open.
------------------------------------------------------------------------------
Can Spawn Notebook                                                    | FAIL |
No browser is open.
------------------------------------------------------------------------------
Can Launch Python3 Smoke Test Notebook                                | FAIL |
No browser is open.
------------------------------------------------------------------------------
Test-Odh-Jupyterlab-Notebook                                          | FAIL |
4 tests, 0 passed, 4 failed
==============================================================================

Updated dockerfile Chromedriver_ver to see if that resolves the issue with the test.

How Has This Been Tested?

Need to run automated tests to validate change.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2022

Hi @strangiato. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thx. You beat me to this PR

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS, strangiato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 3, 2022
@openshift-ci openshift-ci bot merged commit 9f5eaa7 into opendatahub-io:master Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants