Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Restore OpenShift Pipelines component for use as a dependency #643

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Aug 15, 2022

Description

Restore the openshift-pipelines component to the CI tests for future components that may rely on OpenShift pipelines

How Has This Been Tested?

Manually tested using the CI container outlines in tests

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive
Copy link
Contributor

/approve

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Aug 15, 2022

/retest

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@LaVLaS LaVLaS force-pushed the ci-test-openshift-pipelines branch from a22266f to fbda6db Compare August 16, 2022 11:43
@openshift-ci openshift-ci bot removed the lgtm label Aug 16, 2022
@rimolive
Copy link
Contributor

/lgtm

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6664c22 into opendatahub-io:master Aug 16, 2022
@LaVLaS LaVLaS deleted the ci-test-openshift-pipelines branch August 16, 2022 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants