This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Parametrize ML Pipelines deployment #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
LaVLaS
reviewed
Aug 19, 2022
|
/hold Putting this on hold until we can resolve the CI test failures for ml-pipelines on OCP 4.10 that are described in https://github.com/opendatahub-io/odh-manifests/issues/653#issuecomment-1221216051 |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
rimolive
force-pushed
the
rmartine
branch
2 times, most recently
from
b76f1f2
to
1a4d948
Compare
anishasthana
approved these changes
Aug 26, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a way to parametrize ML Pipelines deployment
Description
This PR adds parametrization on configmaps and secrets required to deploy ML Pipelines.
Why this change is required?
Because ML Pipelines manifests brings default integrations with underlying components (database, object store), we need to at least give users a way to setup things like database credentials and others to avoid using the default values used in the manifests.
How Has This Been Tested?
Using the manifests as is, it will deploy ML Pipelines the same as before, but now it is possible to override the database secrets, as an example.
Merge criteria:
Default deployment must work as is.