Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Fix ML Pipelines Tests #661

Conversation

rimolive
Copy link
Contributor

@rimolive rimolive commented Aug 23, 2022

Fix the ML Pipelines CI Tests #653

Description

A change in how to check if the Pipeline Run exists after creation was added

How Has This Been Tested?

$ cd tests
$ make tests
$ make run TESTS_REGEX=ml-pipelines

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rimolive rimolive force-pushed the rmartine-fix-ml-pipeline-tests branch from fddf19b to 4003cf2 Compare August 24, 2022 08:59
@LaVLaS
Copy link
Contributor

LaVLaS commented Aug 24, 2022

@rimolive I ran another test on OCP 4.11 and it appears like the kfp pipeline api server is not deleting the PipelineRun object during the delete_pipeline function. Can you confirm that it is passing on an OCP 4.10 cluster and the PipelineRun object is deleted after curl -s -X DELETE ${ROUTE}/apis/v1beta1/pipelines/${PIPELINE_ID} runs successfully?

@rimolive rimolive force-pushed the rmartine-fix-ml-pipeline-tests branch from 4003cf2 to d7f8195 Compare August 25, 2022 14:48
@rimolive rimolive force-pushed the rmartine-fix-ml-pipeline-tests branch from d7f8195 to 33560ff Compare August 25, 2022 17:35
@LaVLaS LaVLaS self-requested a review August 25, 2022 17:45
Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Manual execution on an OCP 4.11 cluster worked without any issues

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a80db1 into opendatahub-io:master Aug 25, 2022
@DharmitD
Copy link
Member

/lgtm

@rimolive rimolive deleted the rmartine-fix-ml-pipeline-tests branch September 30, 2022 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants