Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add OWNERS file to each component #666

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add OWNERS file to each component #666

merged 1 commit into from
Sep 1, 2022

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Aug 30, 2022

  • Add OWNERS file to ml-pipelines
  • Add owners file for pachyderm
  • Add ceph-nano OWNERS file
  • Add OWNERS file for model-mesh
  • Add OWNERS to odh-notebook-controller
  • Add OWNERS servicemesh
  • Add OWNERS trino
  • Add OWNERS to odh-dashboard
  • Add OWNERS to hue
  • Add OWNERS for jupyterhub

Signed-off-by: Landon LaSmith LLaSmith@redhat.com

Description

Adds an OWNERS file to every component to ensure that the CI system requires PR reviews from contributors closest to the code change

Closes #646

How Has This Been Tested?

N/A

Merge criteria:

Signoff from the relevant component owners

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@LaVLaS LaVLaS requested review from accorvin, crobby, Jooho and rimolive and removed request for VaishnaviHire August 30, 2022 03:02
@accorvin
Copy link
Member

/approve

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Aug 30, 2022

/hold
Putting a hold on this until I get approval from key contributors in the OWNERS file

@openshift-ci openshift-ci bot added the do-not-merge/hold Hold off on merging (provide reason in comment) label Aug 30, 2022
@Jooho
Copy link
Contributor

Jooho commented Aug 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 30, 2022
@crobby
Copy link
Contributor

crobby commented Aug 30, 2022

In general, I think we should strive to have more than 1 person listed in each owners file

anishasthana
anishasthana suggested changes Aug 30, 2022
View reviewed changes
model-mesh/OWNERS Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label Aug 30, 2022
anishasthana
anishasthana reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a couple of OWNERS files with single approvers. Imo we should ahve at least 2 for each component.

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Aug 30, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Hold off on merging (provide reason in comment) label Aug 30, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Aug 30, 2022

/retest

@LaVLaS
Add OWNERS file to each component
c40e5fa 
* Add OWNERS file to ml-pipelines
* Add owners file for pachyderm
* Add ceph-nano OWNERS file
* Add OWNERS file for model-mesh
* Add OWNERS to odh-notebook-controller
* Add OWNERS servicemesh
* Add OWNERS trino
* Add OWNERS to odh-dashboard
* Add OWNERS to hue
* Add OWNERS for jupyterhub

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 1, 2022

/approve

Approving based on previous +1

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: accorvin, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 1, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2022

@LaVLaS: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@accorvin
Copy link
Member

accorvin commented Sep 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 1, 2022
@LaVLaS LaVLaS merged commit c1c9c33 into opendatahub-io:master Sep 1, 2022
@LaVLaS LaVLaS deleted the add-component-owners branch September 1, 2022 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anishasthana anishasthana anishasthana requested changes

@accorvin accorvin Awaiting requested review from accorvin

@crobby crobby Awaiting requested review from crobby

@Jooho Jooho Awaiting requested review from Jooho

@rimolive rimolive Awaiting requested review from rimolive

Assignees

@Jooho Jooho

@accorvin accorvin

@anishasthana anishasthana

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OWNERS to each component's manifest directory
5 participants
@LaVLaS @accorvin @Jooho @crobby @anishasthana