This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
Update odh-dashboard to v2.2.1 #675
Merged
openshift-merge-robot
merged 2 commits into
opendatahub-io:master
from
LaVLaS:odh-dashboard/release-2.1.1
Sep 30, 2022
Merged
Update odh-dashboard to v2.2.1 #675
openshift-merge-robot
merged 2 commits into
opendatahub-io:master
from
LaVLaS:odh-dashboard/release-2.1.1
Sep 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
/retest |
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
from
September 13, 2022 04:30
4b26258
to
ba2cfcb
Compare
/retest |
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
5 times, most recently
from
September 14, 2022 16:13
6b1759f
to
9c56a0a
Compare
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
4 times, most recently
from
September 22, 2022 19:17
2fe13b1
to
21642e2
Compare
/retest |
LaVLaS
changed the title
Update odh-dashboard to v2.2.1
WIP: Update odh-dashboard to v2.2.1
Sep 23, 2022
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
from
September 23, 2022 14:19
21642e2
to
c01e68b
Compare
/retest |
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
3 times, most recently
from
September 26, 2022 21:36
d90e61f
to
fbbb7f9
Compare
LaVLaS
changed the title
WIP: Update odh-dashboard to v2.2.1
Update odh-dashboard to v2.2.1
Sep 27, 2022
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
2 times, most recently
from
September 27, 2022 15:59
e7a3349
to
d3d844a
Compare
/retest |
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
from
September 27, 2022 17:32
d3d844a
to
88794b8
Compare
Updates odh-dashboard to v2.2.1 and adds CI tests to verify the notebook controller integration with the Dashboard notebook spawner UI Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
LaVLaS
force-pushed
the
odh-dashboard/release-2.1.1
branch
from
September 27, 2022 19:10
88794b8
to
5dc04a3
Compare
cfchase
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested deployment.
/lgtm
dlabaj
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfchase, dlabaj, LaVLaS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates odh-dashboard to v2.2.1. and adds CI tests to verify the notebook controller integration with the Dashboard notebook spawner UI
Removes JupyterHub from CI test runs since it is planned for deprecation
How Has This Been Tested?
Tested locally by deploying the odh-dashboard:v2.2.1 successfully and running the odh-manifests CI container against the same local deployment
Disabling the odh-dashboard REST API tests because it requires the testuser to have cluster-admin permissions. See opendatahub-io/odh-dashboard#548
Merge criteria:
odh-dashboard:v2.2.1 deploys successfully and can spawn notebooks. CI tests all pass