Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update odh-dashboard to v2.2.1 #675

Merged

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Sep 12, 2022

Description

Updates odh-dashboard to v2.2.1. and adds CI tests to verify the notebook controller integration with the Dashboard notebook spawner UI

Removes JupyterHub from CI test runs since it is planned for deprecation

How Has This Been Tested?

Tested locally by deploying the odh-dashboard:v2.2.1 successfully and running the odh-manifests CI container against the same local deployment

Disabling the odh-dashboard REST API tests because it requires the testuser to have cluster-admin permissions. See opendatahub-io/odh-dashboard#548

Merge criteria:

odh-dashboard:v2.2.1 deploys successfully and can spawn notebooks. CI tests all pass

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@LaVLaS LaVLaS linked an issue Sep 12, 2022 that may be closed by this pull request
3 tasks
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 12, 2022

/retest

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 13, 2022

/retest

@LaVLaS LaVLaS force-pushed the odh-dashboard/release-2.1.1 branch 5 times, most recently from 6b1759f to 9c56a0a Compare September 14, 2022 16:13
@LaVLaS LaVLaS changed the title Update odh-dashboard to v2.1.1 Update odh-dashboard to v2.2.0 Sep 22, 2022
@LaVLaS LaVLaS force-pushed the odh-dashboard/release-2.1.1 branch 4 times, most recently from 2fe13b1 to 21642e2 Compare September 22, 2022 19:17
@LaVLaS LaVLaS changed the title Update odh-dashboard to v2.2.0 Update odh-dashboard to v2.2.1 Sep 22, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 23, 2022

/retest

@LaVLaS LaVLaS changed the title Update odh-dashboard to v2.2.1 WIP: Update odh-dashboard to v2.2.1 Sep 23, 2022
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 26, 2022

/retest

@LaVLaS LaVLaS force-pushed the odh-dashboard/release-2.1.1 branch 3 times, most recently from d90e61f to fbbb7f9 Compare September 26, 2022 21:36
@LaVLaS LaVLaS changed the title WIP: Update odh-dashboard to v2.2.1 Update odh-dashboard to v2.2.1 Sep 27, 2022
@LaVLaS LaVLaS force-pushed the odh-dashboard/release-2.1.1 branch 2 times, most recently from e7a3349 to d3d844a Compare September 27, 2022 15:59
@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 27, 2022

/retest

Updates odh-dashboard to v2.2.1 and adds CI tests to verify the notebook
controller integration with the Dashboard notebook spawner UI

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
Copy link
Member

@cfchase cfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested deployment.

/lgtm

Copy link

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Sep 30, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfchase, dlabaj, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c645e88 into opendatahub-io:master Sep 30, 2022
@LaVLaS LaVLaS deleted the odh-dashboard/release-2.1.1 branch September 30, 2022 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update odh-dashboard to version 2.2.1
5 participants